fix: handle integer JSON values in server mode parseFloat#167
Open
NicoHinderling wants to merge 1 commit intodmtrKovalenko:mainfrom
Open
fix: handle integer JSON values in server mode parseFloat#167NicoHinderling wants to merge 1 commit intodmtrKovalenko:mainfrom
NicoHinderling wants to merge 1 commit intodmtrKovalenko:mainfrom
Conversation
The `parseFloat` helper only checked for `.float` JSON values, causing
integer values like `{"threshold": 0}` to silently fall back to the
default (0.1). This is because zig's std.json parser distinguishes
between `0` (integer) and `0.0` (float).
This made `threshold: 0` behave as `threshold: 0.1` in server mode,
while the CLI `--threshold 0` worked correctly.
The fix adds an `.integer` branch matching the pattern already used
in `parseDiffOverlay`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #166
Summary
parseFloatin server mode only matched.floatJSON values, causing integer values like{"threshold": 0}to silently fall back to the default (0.1).integerbranch toparseFloat, matching the pattern already used inparseDiffOverlay"threshold": 0(integer) detects diffs correctly in server modeContext
Zig's
std.jsonparser distinguishes between0(.integer) and0.0(.float). Since the JSON spec doesn't distinguish these, callers reasonably send"threshold": 0and expect it to work — but it was silently ignored.The CLI path (
--threshold 0) is unaffected since it parses the string argument directly.