Skip to content

remove deprecated "logentries" logging driver from docs, completion, and tests#4711

Merged
thaJeztah merged 6 commits intodocker:masterfrom
thaJeztah:remove_logentries
Dec 13, 2023
Merged

remove deprecated "logentries" logging driver from docs, completion, and tests#4711
thaJeztah merged 6 commits intodocker:masterfrom
thaJeztah:remove_logentries

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

vendor: github.com/docker/docker v25.0.0-beta.2

No changes, as it's the same commit: moby/moby@92884c2...v25.0.0-beta.2

vendor: github.com/docker/docker f3cc93630ed8 (v25.0.0-dev)

full diff: moby/moby@v25.0.0-beta.2...f3cc936

contrib/completion: remove logentries logging-driver

This driver has been deprecated and removed because the service
is no longer operational.

docs, man: remove logentries logging-driver

This driver has been deprecated and removed because the service
is no longer operational. Remove it from the sample output.

cli/command: remove "logentries" driver from tests and fixtures

This driver has been deprecated and removed because the service
is no longer operational. Remove it from the tests to better reflect
reality.

docs/deprecated: mark logentries logging-driver as "removed"

This driver has been deprecated and removed because the service
is no longer operational. Update the deprecated features docs to
mention it's been fully removed in Docker v25.0.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

No changes, as it's the same commit: moby/moby@92884c2...v25.0.0-beta.2

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: moby/moby@v25.0.0-beta.2...f3cc936

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This driver has been deprecated and removed because the service
is no longer operational.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This driver has been deprecated and removed because the service
is no longer operational. Remove it from the sample output.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This driver has been deprecated and removed because the service
is no longer operational. Remove it from the tests to better reflect
reality.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This driver has been deprecated and removed because the service
is no longer operational. Update the deprecated features docs to
mention it's been fully removed in Docker v25.0.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 13, 2023

Codecov Report

Merging #4711 (77e67a0) into master (103840e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4711   +/-   ##
=======================================
  Coverage   59.68%   59.68%           
=======================================
  Files         287      287           
  Lines       24865    24865           
=======================================
  Hits        14841    14841           
  Misses       9138     9138           
  Partials      886      886           

@thaJeztah thaJeztah marked this pull request as ready for review December 13, 2023 13:07
@thaJeztah thaJeztah requested a review from albers as a code owner December 13, 2023 13:07
@thaJeztah thaJeztah requested review from dvdksn and vvoland and removed request for albers December 13, 2023 13:07
@thaJeztah
Copy link
Copy Markdown
Member Author

whoop; CI passed on the first run; this one should be ready for review as well 👍

Copy link
Copy Markdown
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member Author

Thanks @albers ❤️ (as always!)

@thaJeztah thaJeztah merged commit 8f90d98 into docker:master Dec 13, 2023
@thaJeztah thaJeztah deleted the remove_logentries branch December 13, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants