Skip to content

Dockerfile: update to xx 1.4.0#4937

Merged
thaJeztah merged 1 commit intodocker:masterfrom
crazy-max:update-xx
Mar 12, 2024
Merged

Dockerfile: update to xx 1.4.0#4937
thaJeztah merged 1 commit intodocker:masterfrom
crazy-max:update-xx

Conversation

@crazy-max
Copy link
Copy Markdown
Member

related to #4933 (comment)

- What I did

update xx to 1.4.0

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.43%. Comparing base (d06f137) to head (adb0180).
Report is 921 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4937      +/-   ##
==========================================
- Coverage   61.47%   61.43%   -0.04%     
==========================================
  Files         289      289              
  Lines       20226    20237      +11     
==========================================
  Hits        12433    12433              
- Misses       6892     6903      +11     
  Partials      901      901              

@thaJeztah
Copy link
Copy Markdown
Member

Hm... looks like this one is definitely flaky;

--- FAIL: TestPromptForConfirmation (0.60s)
    --- FAIL: TestPromptForConfirmation/case=reader_closed (0.38s)
        utils_test.go:222: PromptForConfirmation did not return after promptReader was closed
FAIL
panic: send on closed channel

goroutine 127 [running]:
github.com/docker/cli/cli/command_test.TestPromptForConfirmation.func8.2()
	/Users/runner/work/cli/cli/src/github.com/docker/cli/cli/command/utils_test.go:209 +0x6d
created by github.com/docker/cli/cli/command_test.TestPromptForConfirmation.func8 in goroutine 126
	/Users/runner/work/cli/cli/src/github.com/docker/cli/cli/command/utils_test.go:207 +0x3aa
FAIL	github.com/docker/cli/cli/command	0.691s

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! thought I LGTM'd, but I probably forgot because I had to kick CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants