list/tree: No extra spacing for graphdriver#5356
Merged
laurazard merged 1 commit intodocker:masterfrom Aug 19, 2024
Merged
Conversation
Don't output the extra spacing around the images when none of the top-level image entries has any children. This makes the list look better when ran against the graphdrivers image store. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
added
status/2-code-review
area/ux
containerd-integration
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5356 +/- ##
==========================================
- Coverage 60.93% 60.92% -0.02%
==========================================
Files 304 304
Lines 21335 21340 +5
==========================================
Hits 13001 13001
- Misses 7404 7409 +5
Partials 930 930 |
laurazard
approved these changes
Aug 19, 2024
krissetto
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't output the extra spacing around the images when none of the top-level image entries has any children.
This makes the list look better when ran against the graphdrivers image store.
- What I did
- How I did it
- How to verify it
Before
Graphdrivers
Containerd
After
Graphdrivers
Containerd (no changes)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)