e2e: skip flaky test#5945
Merged
thaJeztah merged 1 commit intodocker:masterfrom Mar 21, 2025
Merged
Conversation
Signed-off-by: Stephen Day <stephen.day@docker.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5945 +/- ##
==========================================
+ Coverage 59.43% 59.45% +0.02%
==========================================
Files 358 358
Lines 29765 29765
==========================================
+ Hits 17690 17698 +8
+ Misses 11111 11102 -9
- Partials 964 965 +1 🚀 New features to boost your workflow:
|
thaJeztah
approved these changes
Mar 21, 2025
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
yeah, let's skip this one. not sure what's causing this, but I somewhat suspect tests running in parallel using the same port. We're very likely gonna deprecate the client-side docker content trust, so not worth investing time into debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Test failed in https://github.com/docker/cli/actions/runs/13958201073/job/39074237116?pr=5858. Skipping this rather than keep a test that doesn't provide value.
- How I did it
t.Skipat top of test.- How to verify it
See that the test shows as skipped.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)