Skip to content

e2e: skip flaky test#5945

Merged
thaJeztah merged 1 commit intodocker:masterfrom
stevvooe:sjd/remove-flaky-test
Mar 21, 2025
Merged

e2e: skip flaky test#5945
thaJeztah merged 1 commit intodocker:masterfrom
stevvooe:sjd/remove-flaky-test

Conversation

@stevvooe
Copy link
Copy Markdown
Contributor

- What I did

Test failed in https://github.com/docker/cli/actions/runs/13958201073/job/39074237116?pr=5858. Skipping this rather than keep a test that doesn't provide value.

- How I did it

t.Skip at top of test.

- How to verify it

See that the test shows as skipped.

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Stephen Day <stephen.day@docker.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.45%. Comparing base (b199ece) to head (4a80c6d).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5945      +/-   ##
==========================================
+ Coverage   59.43%   59.45%   +0.02%     
==========================================
  Files         358      358              
  Lines       29765    29765              
==========================================
+ Hits        17690    17698       +8     
+ Misses      11111    11102       -9     
- Partials      964      965       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yeah, let's skip this one. not sure what's causing this, but I somewhat suspect tests running in parallel using the same port. We're very likely gonna deprecate the client-side docker content trust, so not worth investing time into debugging.

@thaJeztah thaJeztah added this to the 28.0.3 milestone Mar 21, 2025
@thaJeztah thaJeztah merged commit 30cac75 into docker:master Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants