cli/trust: GetNotaryRepository: remove intermediate var#5961
cli/trust: GetNotaryRepository: remove intermediate var#5961vvoland merged 1 commit intodocker:masterfrom
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
| Transport: authTransport, | ||
| Credentials: creds, | ||
| Scopes: []auth.Scope{scope}, | ||
| ClientID: registry.AuthClientID, |
There was a problem hiding this comment.
This one made me wonder; I see we're constructing token handlers in different places; for this one, and some paths in docker/docker, we set the ClientID; https://github.com/moby/moby/blob/330857ad0ffbc8114556f7886997fc43d7be4aad/distribution/registry.go#L123
But in cli/registry/client we use auth.NewTokenHandler
cli/cli/registry/client/endpoint.go
Lines 95 to 96 in 2b0631f
Which means we end up with github.com/docker/distribution picking a default;
cli/vendor/github.com/docker/distribution/registry/client/auth/session.go
Lines 328 to 332 in 2b0631f
Which would be registry-client
Leftover from another branch I was working on 😂
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)