only close plugin server if actually created#6123
Merged
thaJeztah merged 1 commit intodocker:masterfrom Jun 10, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6123 +/- ##
=======================================
Coverage 55.03% 55.04%
=======================================
Files 361 361
Lines 30153 30152 -1
=======================================
Hits 16596 16596
+ Misses 12599 12598 -1
Partials 958 958 🚀 New features to boost your workflow:
|
vvoland
approved these changes
Jun 9, 2025
Benehiko
approved these changes
Jun 10, 2025
thaJeztah
reviewed
Jun 10, 2025
| defer func() { | ||
| // Close the server when plugin execution is over, so that in case | ||
| // it's still open, any sockets on the filesystem are cleaned up. | ||
| _ = srv.Close() |
Member
There was a problem hiding this comment.
There's another call to srv.Close() further down; that one should probably be gated by a if srv != nil as well;
Lines 331 to 337 in 9e50654
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
don't defer
srv.Close()if srv was not successfully created (nil pointer)