cli/command/container: remove use of ExecOptions.Detach as intermediate#6137
Merged
thaJeztah merged 1 commit intodocker:masterfrom Jun 17, 2025
Merged
cli/command/container: remove use of ExecOptions.Detach as intermediate#6137thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
This field was added in [moby@5130fe5d38837302e], which added it for use as intermediate struct when parsing CLI flags (through `runconfig.ParseExec`) in [moby@c786a8ee5e9db8f5f]. Commit [moby@9d9dff3d0d9e92adf] rewrote the CLI to use Cobra, and as part of this introduced a separate `execOptions` type in `api/client/container`, however the ExecOptions.Detach field was still used as intermediate field to store the flag's value. Given that the client doesn't use this field, let's remove its use to prevent giving the impression that it's used anywhere. [moby@5130fe5d38837302e]: moby/moby@5130fe5 [moby@c786a8ee5e9db8f5f]: moby/moby@c786a8e [moby@9d9dff3d0d9e92adf]: moby/moby@9d9dff3 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
kind/refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6137 +/- ##
==========================================
- Coverage 55.04% 55.03% -0.01%
==========================================
Files 361 361
Lines 30152 30151 -1
==========================================
- Hits 16596 16595 -1
Misses 12598 12598
Partials 958 958 🚀 New features to boost your workflow:
|
Benehiko
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to;
This field was added in moby@5130fe5d38837302e, which added it for use as intermediate struct when parsing CLI flags (through
runconfig.ParseExec) in moby@c786a8ee5e9db8f5f.Commit moby@9d9dff3d0d9e92adf rewrote the CLI to use Cobra, and as part of this introduced a separate
execOptionstype inapi/client/container, however the ExecOptions.Detach field was still used as intermediate field to store the flag's value.Given that the client doesn't use this field, let's remove its use to prevent giving the impression that it's used anywhere.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)