Add "Composer Lint" job to CI pipeline#31
Conversation
phansys
force-pushed
the
composer_lint
branch
4 times, most recently
from
9bf3e50 to
a595a81
Compare
| - name: "Composer validate" | ||
| run: "composer validate" |
There was a problem hiding this comment.
Doesn't composer-normalize already run this validation step?
There was a problem hiding this comment.
Even if that is not explicitly stated in the docs, I guess the validation is already covered (ergebnis/composer-normalize#297, ergebnis/composer-normalize#406).
| inputs: | ||
| php-version: | ||
| description: "The PHP version to use when running the job" | ||
| default: "8.0" |
There was a problem hiding this comment.
Why not 8.1?
| default: "8.0" | |
| default: "8.1" |
|
Can you please test this before we merge it? Here is how you can do so: doctrine/DoctrineMigrationsBundle@9321c8c |
Thank you @greg0ire! |
|
Well I'm confused, since this is a pull request, isn't it?
EDIT: ah maybe you can use it in the caller side rather than on the callee side? |
greg0ire
left a comment
greg0ire
left a comment
There was a problem hiding this comment.
Please add a workflow template and a properties file in the workflow-templates directory
|
Thanks @phansys ! I'm going to tag a new version with this! |
3 participants
Follows doctrine/DoctrineBundle#1540 (comment).
I was not able to leverage the Coding Standards workflow as I think (currently) there is no simple way to filter a single job.