Skip to content

Remove unused parameter#3395

Merged
martincostello merged 1 commit into
masterfrom
refactor-method
May 1, 2025
Merged

Remove unused parameter#3395
martincostello merged 1 commit into
masterfrom
refactor-method

Conversation

@martincostello

Copy link
Copy Markdown
Collaborator

- Remove unused parameter from change in #3377.
- Simplify duplicated condition.
@martincostello martincostello added this to the v8.1.2 milestone May 1, 2025
@martincostello martincostello enabled auto-merge (rebase) May 1, 2025 10:47
@codecov-commenter

codecov-commenter commented May 1, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.89%. Comparing base (557d074) to head (a0ca64b).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...Core.SwaggerGen/SchemaGenerator/SchemaGenerator.cs 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3395      +/-   ##
==========================================
+ Coverage   83.67%   84.89%   +1.22%     
==========================================
  Files          84       84              
  Lines        3290     3291       +1     
  Branches      578      579       +1     
==========================================
+ Hits         2753     2794      +41     
+ Misses        537      497      -40     
Flag Coverage Δ
Linux 65.26% <83.33%> (-18.41%) ⬇️
Windows 65.26% <83.33%> (-18.41%) ⬇️
macOS 83.65% <83.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello merged commit dae55f1 into master May 1, 2025
@martincostello martincostello deleted the refactor-method branch May 1, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants