Fix unit tests, target framework 4.5, consolidate nuget references#1286
Open
rlesavre wants to merge 3 commits intodomaindrivendev:masterfrom
Open
Fix unit tests, target framework 4.5, consolidate nuget references#1286rlesavre wants to merge 3 commits intodomaindrivendev:masterfrom
rlesavre wants to merge 3 commits intodomaindrivendev:masterfrom
Conversation
added 3 commits
December 20, 2018 12:22
- fix unit tests (missing resource, and EOL issues) - use of the static version of swagger-ui that coded against - (https://github.com/swagger-api/swagger-ui/tree/64dc3060b3700b12e466f8d67b7d7ec3574b015f) - update to .NET 4.5 - consolidate dependency Note: - Need to install in VS: - NUnit Test 3 Adapter - If swagger-ui needs to be updated, need to fetch submodule swagger-ui (what about tags ? like https://github.com/swagger-api/swagger-ui/tree/v2.1.5) - git submodule update --init --force --remote - Need to build swagger-ui - npm install - npm run build - copy dist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:
Readme notes and use of the static version of swagger-ui that coded against are not candidates to the PR, but in the meantime usefull in my repo.