Skip to content

Add an option to throw an error if an attribute you are trying to set doesn't exist on the model you are loading #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ysoussov wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add an option to throw an error if an attribute you are trying to set doesn't exist on the model you are loading #81

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
905def2
add an option to throw an error if an attribute doesn't exist on a mo…
Oct 23, 2017
d47967f
correct spacing
Oct 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,11 @@ Loader.prototype.prepFixtureData = function(data, Model) {
if (Model.attributes.hasOwnProperty(key)) {
result[key] = val;
} else {
console.warn('attribute "' + key +"' not defined on model '" + Model.name + "'.");
if (self.options.throwErrorOnUndefinedAttribute === true) {
Copy link
Copy Markdown
Collaborator

@matmar10 matmar10 Apr 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest: errorOnUndefinedAttribute.

Also, if (self.options.throwErrorOnUndefinedAttribute) is sufficient... anything truthy should be OK.

throw new Error('attribute "' + key +"' not defined on model '" + Model.name + "'.");
} else {
log.warn('attribute "' + key +"' not defined on model '" + Model.name + "'.");
Copy link
Copy Markdown
Collaborator

@matmar10 matmar10 Apr 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should actually be log() ... log is expected to be just a plain function

}
}
}
});
Expand Down
⚡