Derive token_endpoint_auth_methods_supported from Doorkeeper's client_credentials config#236
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Add option to disable client_secret_basic authentication
Derive Mar 14, 2026
token_endpoint_auth_methods_supported from Doorkeeper's client_credentials config
…redentials config Co-authored-by: nbulaj <1443426+nbulaj@users.noreply.github.com>
1ecb78d to
8f9e6a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
token_endpoint_auth_methods_supportedin the OIDC discovery response was hardcoded to[client_secret_basic, client_secret_post], ignoring Doorkeeper'sclient_credentialsconfiguration which already controls which methods are accepted.Changes
discovery_controller.rb: Replace hardcoded array with a dynamic mapping from Doorkeeper'sclient_credentials_methods(:from_basic→client_secret_basic,:from_params→client_secret_post)discovery_controller_spec.rb: Add coverage forfrom_basic-only,from_params-only, and both-configured casesExample
Default Doorkeeper config (
[:from_basic, :from_params]) preserves the existing behaviour.Original prompt
client_secret_basicfortoken_endpoint_auth_methods_supported? #178🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.