Fix dynamic client registration returning hashed secret when hash_application_secrets is enabled#237
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix dynamic client registration to return plaintext secret
Fix dynamic client registration returning hashed secret when Mar 16, 2026
hash_application_secrets is enabled
…application_secrets
6bde945 to
0799451
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Doorkeeper's
hash_application_secretsis enabled, the dynamic client registration endpoint was returning the BCrypt hash instead of the plaintext secret, making the registered client unusable.Changes
plaintext_secret || secretinregistration_response—plaintext_secretis populated by Doorkeeper on the in-memory object immediately aftercreate!, before the secret is hashed and persisted. Falls back tosecretwhen hashing is disabled.This mirrors the fix Doorkeeper applied to its own UI flow in #1246.
Original prompt
hash_application_secrets#231💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.