Skip to content

Test tests#240

Closed
nbulaj wants to merge 1 commit into
masterfrom
tests-test
Closed

Test tests#240
nbulaj wants to merge 1 commit into
masterfrom
tests-test

Conversation

@nbulaj

@nbulaj nbulaj commented Apr 10, 2026

Copy link
Copy Markdown
Member

No description provided.

@nbulaj

nbulaj commented Apr 10, 2026

Copy link
Copy Markdown
Member Author

Hello @55728

I feel like this PR broken actually this extension. Can we take a look please?

NameError:
  uninitialized constant Doorkeeper::AccessGrant

Or openid-connect has some problems in the tests 👀

https://github.com/doorkeeper-gem/doorkeeper-openid_connect/actions/runs/24230937892/job/70742227853?pr=240

UPD: ok looks like we need the same added to extension as well

https://github.com/doorkeeper-gem/doorkeeper-openid_connect/pull/241/changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a temporary STDOUT print during Doorkeeper OpenID Connect configuration.

Changes:

  • Inserted a puts statement inside Doorkeeper::OpenidConnect.configure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/doorkeeper/openid_connect/config.rb
@55728

55728 commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the quick fix! That's exactly the same change I was going to propose — #1804 deferred model loading in doorkeeper, but I missed updating run_hooks on the extension side.

I checked the other doorkeeper extensions and openid_connect is the only one affected:

Extension ORM hooks Status
openid_connect run_hooks calls access_grant_model eagerly Affected — fixed by #241
mongodb Uses on_load(:mongoid) Safe
device_authorization_grant initialize_models! with on_load(:active_record) Safe
ciba initialize_models! with on_load(:active_record) Safe
jwt No ORM interaction Safe
grants_assertion No ORM interaction Safe

Sorry about the breakage! 🙏

@nbulaj

nbulaj commented Apr 13, 2026

Copy link
Copy Markdown
Member Author

No worries, I believe it's fixed now. So gonna to close this PR, Thanks!

@nbulaj nbulaj closed this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants