Skip to content

Use full URL to link test suites#89

Merged
dorny merged 2 commits intodevfrom
fix-suite-links
Mar 31, 2021
Merged

Use full URL to link test suites#89
dorny merged 2 commits intodevfrom
fix-suite-links

Conversation

@dorny
Copy link
Copy Markdown
Owner

@dorny dorny commented Mar 31, 2021

GitHub UI for some unknown reason navigates user to check run with check_suite_focus=true query argument. With this argument unfortunately navigation to document ID with #something doesn't work.

This patch tries to fix it by using full URL.
If user has the check_suite_focus=true URL it will cause reload of the page.
Afterwards navigation within document should work normally.

dorny added 2 commits March 31, 2021 23:22
GitHub UI for some unknown reason navigates user to check run with `check_suite_focus=true` query argument. With this argument unfortunately navigation to document ID with `#something` doesn't work
Adds full URL in place previous commit missed
@dorny dorny merged commit 39f7ac7 into dev Mar 31, 2021
@dorny dorny deleted the fix-suite-links branch March 31, 2021 21:33
@dorny dorny mentioned this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant