Skip aka.ms productVersion links for General Testing channels#17007
Open
akoeplinger wants to merge 1 commit into
Open
Skip aka.ms productVersion links for General Testing channels#17007akoeplinger wants to merge 1 commit into
akoeplinger wants to merge 1 commit into
Conversation
VMR builds emit multiple productVersion.txt blobs (aspnetcore, runtime, sdk, windowsdesktop) that flatten to the same aka.ms shortlink and fail publishing with DuplicateLink. Use UnifiedBuildAkaMSDoNotCreateLinkPatterns for General Testing (529) and General Testing Internal (1647), matching all other channels that receive VMR builds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates General Testing publishing channel configuration so VMR promotions don’t attempt to create duplicate flattened productversion.txt aka.ms shortlinks (which currently causes publishing failures due to duplicate link creation).
Changes:
- Switch channel 529 (
generaltesting) to useUnifiedBuildAkaMSDoNotCreateLinkPatterns(excludesproductversion). - Switch channel 1647 (
generaltestinginternal) to useUnifiedBuildAkaMSDoNotCreateLinkPatternsfor parity with other VMR-receiving channels.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VMR builds emit multiple
productVersion.txtblobs (aspnetcore, runtime, sdk, windowsdesktop) at different paths. WithFlatten = true(the default for aka.ms link creation) they all collapse to the same shortlinkaka.ms/dotnet/generaltesting/daily/productversion.txt, and publishing fails with:All other channels that receive VMR builds use
UnifiedBuildAkaMSDoNotCreateLinkPatterns, which adds aproductversionexclusion on top of the defaults. The General Testing channels (529 and 1647) were the only non-VS testing channels still usingDefaultAkaMSDoNotCreateLinkPatterns, so they break as soon as a VMR build is promoted there.Switch both General Testing channels to use
UnifiedBuildAkaMSDoNotCreateLinkPatternsto match the rest.