[Components][E2E] Stabilize virtualization test setup after scroll#66194
Open
ilonatommy wants to merge 1 commit intomainfrom
Open
[Components][E2E] Stabilize virtualization test setup after scroll#66194ilonatommy wants to merge 1 commit intomainfrom
ilonatommy wants to merge 1 commit intomainfrom
Conversation
The flaky server virtualization failure happens in the setup phase that scrolls past the overscan window and assumes the rendered range has already caught up. Add a helper that reapplies the target offset and waits for the virtualized window to converge before the prepend/append assertions begin. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Stabilizes the server-side virtualization dynamic content E2E tests by making the “scroll past overscan” setup phase wait for the rendered window to actually advance before running the viewport-preservation assertions.
Changes:
- Added a shared helper to scroll to a target offset and poll until the first rendered item index advances beyond a threshold, then wait for scroll stabilization.
- Updated the prepend/append dynamic content virtualization tests to use the new stabilized scroll helper (keeping the core assertions unchanged).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The intermittent failure has been happening in the preparation stage, where the test sets
scrollTop = 5000and then immediately expects the rendered range to have moved beyond the overscan window. In server mode that can race with the async virtualization update, so the test can fail before it even reaches the real prepend assertion.Test