Skip to content

Sync eng/common/{cross,native} with arcade#5892

Open
am11 wants to merge 2 commits into
dotnet:mainfrom
am11:chore/sync-eng-common
Open

Sync eng/common/{cross,native} with arcade#5892
am11 wants to merge 2 commits into
dotnet:mainfrom
am11:chore/sync-eng-common

Conversation

@am11

@am11 am11 commented Jun 19, 2026

Copy link
Copy Markdown
Member

It stopped syncing automatically few months ago for some reason, so new platforms' configs aren't showing up. See #5858 (comment).

@am11

am11 commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

cc @hoyosjs, @akoeplinger it includes dotnet/arcade#17027.

hoyosjs
hoyosjs previously approved these changes Jun 19, 2026
@hoyosjs

hoyosjs commented Jun 19, 2026

Copy link
Copy Markdown
Member

@am11 - have you noticed this in other repos? And is it just these dirs?

@am11

am11 commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

@am11 - have you noticed this in other repos?

Yup, in SDK and aspnetcore. Up until last month, only runtime and diagnostics were using native infra from eng/common. Now that aspnetcore and SDK tools are AOT published for few weeks, we should sync the entire eng/common without any filtering across arcade-powered repos. IMO, it's much simpler (and it seems like the original intent when eng/common/README.md file was first written..).

And is it just these dirs?

Just copied the entire dir, pushed a commit. Seems like there was more out of sync, so something is filtering the contents. :/

@am11 am11 requested a review from a team as a code owner June 19, 2026 19:43
@am11

am11 commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

@hoyosjs, turned out additional changes in new eng/common required new dotnet download command which is available in SDK 11.0, so I first merged #5858 to this PR, then updated global.json to 11.0. Note that this is just a "build toolchain" version, it doesn't change <TargetFramework of individual projects.

@hoyosjs

hoyosjs commented Jun 20, 2026

Copy link
Copy Markdown
Member

We can't use .NET 11 SDK in this repo - we use the release branch of arcade

@hoyosjs hoyosjs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the arcade 10 branch

@hoyosjs

hoyosjs commented Jun 20, 2026

Copy link
Copy Markdown
Member

10.0.3xx also has the feature - but I believe it might not be available in source build

@am11 am11 force-pushed the chore/sync-eng-common branch from 39253f3 to 3233398 Compare June 20, 2026 10:18
@am11

am11 commented Jun 20, 2026

Copy link
Copy Markdown
Member Author

@hoyosjs, the MicrosoftDotNetArcadeSdkPackageVersion still points to v10 in this PR. The only thing which has bumped is the toolchain which is capable of handling more versions beyond v10. That should not have any impact on the final product (it still uses the same libraries versions to build the product). If this is a problem, let me know and i will reset to the original shape of PR: sync only eng/common/{cross,native} sub-dirs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants