Remove reflection from UICultureUtilities#83038
Merged
Conversation
…CurrentUICulture API Agent-Logs-Url: https://github.com/dotnet/roslyn/sessions/8d44462b-90ce-417d-b9f9-1b17b7309567 Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jaredpar
April 2, 2026 18:31
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UICultureUtilities.csused reflection to discover and invoke theCultureInfo.CurrentUICulturesetter (falling back toThread.CurrentThread.CurrentUICulture) because the setter wasn't universally available when the code was written. The API is now directly accessible in .NET Standard 2.0+.Changes
TryGetCurrentUICultureSetterandTryGetCurrentThreadUICultureSetterreflection helpers, the static constructor,s_setCurrentUICulturefield, andcurrentUICultureNameconstants_setCurrentUICulture(value)calls withCultureInfo.CurrentUICulture = valuenull-setter early-return guard from all threeWithCurrentUICultureoverloads (no longer needed since the setter is always available)using System.Diagnostics.CodeAnalysisandusing System.ReflectionBefore:
After:
Microsoft Reviewers: Open in CodeFlow