Clean up our newline-fixing extension methods#83043
Open
jasonmalinowski wants to merge 1 commit intodotnet:mainfrom
Open
Clean up our newline-fixing extension methods#83043jasonmalinowski wants to merge 1 commit intodotnet:mainfrom
jasonmalinowski wants to merge 1 commit intodotnet:mainfrom
Conversation
No reason to define extension methods when they'll lose to the framework provided ones.
RikkiGibson
approved these changes
Apr 2, 2026
CyrusNajmabadi
approved these changes
Apr 3, 2026
jjonescz
reviewed
Apr 7, 2026
| public static string ReplaceLineEndings(this string input) | ||
| { | ||
| #if NET6_0_OR_GREATER | ||
| return input.ReplaceLineEndings(); |
Member
There was a problem hiding this comment.
If this is used only in tests, then I guess it's fine. But otherwise, our pattern is to have the method available always for binary compatibility: https://github.com/dotnet/roslyn/blob/main/docs/contributing/target-framework-strategy.md#pattern-for-extension-methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No reason to define extension methods when they'll lose to the framework provided ones.
Microsoft Reviewers: Open in CodeFlow