Fix false CS8619 for ref notnull discard assignment (fixes #82919)#83057
Open
sabaka-chabaka wants to merge 6 commits intodotnet:mainfrom
Open
Fix false CS8619 for ref notnull discard assignment (fixes #82919)#83057sabaka-chabaka wants to merge 6 commits intodotnet:mainfrom
sabaka-chabaka wants to merge 6 commits intodotnet:mainfrom
Conversation
dotnet-policy-service
bot
added
the
Community
Author
|
@dotnet-policy-service agree |
|
Commenter does not have sufficient privileges for PR 83057 in repo dotnet/roslyn |
Author
|
The pipelines is bugged i think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a false positive CS8619 warning when performing a ref discard assignment of a notnull type.
Details
In NullableWalker.VisitDiscardExpression, the code was forcing NullableAnnotation.Annotated if node.IsInferred was true. This caused notnull types to be treated as nullable during discard, leading to incorrect mismatch warnings. Changed to use node.NullableAnnotation directly from the bound node.
Fixes #82919
Microsoft Reviewers: Open in CodeFlow