Skip unmappable source-generated document edits in rename#83080
Draft
dibarbet wants to merge 1 commit intodotnet:mainfrom
Draft
Skip unmappable source-generated document edits in rename#83080dibarbet wants to merge 1 commit intodotnet:mainfrom
dibarbet wants to merge 1 commit intodotnet:mainfrom
Conversation
…unavailable Only include Razor source-generated documents in rename locations when ISourceGeneratedDocumentSpanMappingService can map their spans. Without a mapping service, the edits would produce roslyn-source-generated:// URIs that clients cannot open. The generator will re-run and produce updated output once the regular document edits are applied. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dibarbet
force-pushed
the
rename-generated-razor
branch
from
1232b27 to
ed27d49
Compare
davidwengier
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ISourceGeneratedDocumentSpanMappingService.CanMapSpans returns false for a source-generated document, skip those edits instead of returning them with roslyn-source-generated:// URIs that the client cannot open. The source generator will re-run and produce updated output once the regular document edits are applied.
Related to #83078
Microsoft Reviewers: Open in CodeFlow