Skip to content

Fix SVE2 API for RotateComplex methods#122172

Merged
tannergooding merged 1 commit intodotnet:mainfrom
ylpoonlg:github-sve2_rotatecomplex_api
Dec 4, 2025
Merged

Fix SVE2 API for RotateComplex methods#122172
tannergooding merged 1 commit intodotnet:mainfrom
ylpoonlg:github-sve2_rotatecomplex_api

Conversation

@ylpoonlg
Copy link
Copy Markdown
Contributor

@ylpoonlg ylpoonlg commented Dec 4, 2025

Fixes #121961.

Rename argument names for the following methods:

  • AddSaturateRotateComplex: op1, op2, rotation => left, right, rotation.
  • DotProductRotateComplex: op1, op2, op3, rotation => addend, left, right, rotation.
  • DotProductRotateComplexBySelectedIndex: op1, op2, op3, imm_index, rotation => addend, left, right, rightIndex, rotation.
  • MultiplyAddRoundedDoublingSaturateHighRotateComplex: op1, op2, op3, rotation => addend, left, right, rotation.
  • MultiplyAddRoundedDoublingSaturateHighRotateComplexBySelectedScalar: op1, op2, op3, imm_index, rotation => addend, left, right, rightIndex, rotation.

@dotnet/arm64-contrib @a74nh

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Dec 4, 2025
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

Copy link
Copy Markdown
Contributor

@a74nh a74nh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these are valid changes raised in #121961.
Running my script shows only a reduction in differences between reviewed and implemented.

So, LGTM

@tannergooding tannergooding merged commit 2333e7c into dotnet:main Dec 4, 2025
144 of 146 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Runtime.Intrinsics community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SVE2: Fixup SVE2 Math/bitmanipulate/FP APIs

3 participants