Cleanup null check in Generic.SortedDictionary#126186
Closed
rustamque wants to merge 1 commit intodotnet:mainfrom
Closed
Cleanup null check in Generic.SortedDictionary#126186rustamque wants to merge 1 commit intodotnet:mainfrom
rustamque wants to merge 1 commit intodotnet:mainfrom
Conversation
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-collections |
This was referenced Mar 27, 2026
EgorBo
reviewed
Mar 27, 2026
| { | ||
| return EqualityComparer<TValue>.Default.Equals(node.Item.Value, keyValuePair.Value); | ||
| } | ||
| return EqualityComparer<TValue>.Default.Equals(node.Item.Value, keyValuePair.Value); |
Member
There was a problem hiding this comment.
NOTE: this is a perf regression when value is null as now we end up calling EqualityComparer<TValue>.Default.Equals with a slow runtime lookup and it's not inlined (even with PGO) for reference typed TValue.
Member
|
Thanks for the contribution. Closing per @EgorBo's comment that this is by design and will regress perf in some situations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Containsmethod: Removed the redundantif (keyValuePair.Value == null)branch.EqualityComparer<TValue>.Default.Equalssafely and optimally handles both reference and value types, resolving the warning without behavior changes.Found by Linux Verification Center (linuxtesting.org) with SVACE.