JIT: recognize CORINFO_HELP_BOX in impThrowIfNull#129392
Open
AndyAyersMS wants to merge 1 commit into
Open
Conversation
In Tier0 struct boxes are emitted as direct CORINFO_HELP_BOX helper calls rather than GT_BOX nodes; recognize this form too so Tier0 ThrowIfNull(struct) doesn't allocate. Fixes dotnet#128574. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
area-CodeGen-coreclr
Member
Author
|
@EgorBo PTAL Small number of diffs. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends an existing Tier0-specific importer optimization in Compiler::impThrowIfNull to also recognize value-type boxing that is represented as a direct CORINFO_HELP_BOX helper call (instead of a GT_BOX node). When the pattern is detected, the importer drops the ArgumentNullException.ThrowIfNull call as a no-op while preserving any side effects from evaluating the box helper’s address argument and the valueName argument.
Changes:
- Add a new pattern match for
ArgumentNullException_ThrowIfNull(CORINFO_HELP_BOX(clsHnd, addr), valueName)in Tier0. - Preserve evaluation order/side effects by spilling
addrandvalueNamebefore returningNOP(gtNewNothingNode()).
Member
Author
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Tier0 struct boxes are emitted as direct CORINFO_HELP_BOX helper calls rather than GT_BOX nodes; recognize this form too so Tier0 ThrowIfNull(struct) doesn't allocate.
Fixes #128574.