-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Add support for IServiceProviderIsService #54047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
754dd34
Add support for IServiceProviderIsService
davidfowl b413e7a
PR feedback, add IEnumerable open generic test
davidfowl 81c89f2
PR feedback
davidfowl b556a0e
Update src/libraries/Microsoft.Extensions.DependencyInjection.Abstrac…
davidfowl 6aeff37
Handle built in services as part of IsServce
davidfowl 8f7d3ec
PR feedback
davidfowl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
...es/Microsoft.Extensions.DependencyInjection.Abstractions/src/IServiceProviderIsService.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
|
|
||
| namespace Microsoft.Extensions.DependencyInjection | ||
| { | ||
| /// <summary> | ||
| /// Optional service used to determine if the specified type is resolvable by the <see cref="IServiceProvider"/>. | ||
| /// </summary> | ||
| public interface IServiceProviderIsService | ||
| { | ||
| /// <summary> | ||
| /// Determines if the specified service type is resolvable by the <see cref="IServiceProvider"/>. | ||
| /// </summary> | ||
| /// <param name="serviceType">An object that specifies the type of service object to test.</param> | ||
| /// <returns>true if the specified service is a resolvable, false if it is not.</returns> | ||
|
davidfowl marked this conversation as resolved.
Outdated
|
||
| bool IsService(Type serviceType); | ||
| } | ||
| } | ||
84 changes: 84 additions & 0 deletions
84
...DependencyInjection.Specification.Tests/src/ServiceProviderIsServiceSpecificationTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Text; | ||
| using Microsoft.Extensions.DependencyInjection.Specification.Fakes; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.Extensions.DependencyInjection.Specification | ||
| { | ||
| public abstract class ServiceProviderIsServiceSpecificationTests | ||
|
davidfowl marked this conversation as resolved.
Outdated
davidfowl marked this conversation as resolved.
Outdated
|
||
| { | ||
| protected abstract IServiceProvider CreateServiceProvider(IServiceCollection serviceCollection); | ||
|
|
||
| [Fact] | ||
| public void ExplictServiceRegisterationWithIsService() | ||
| { | ||
| // Arrange | ||
| var collection = new TestServiceCollection(); | ||
| collection.AddTransient(typeof(IFakeService), typeof(FakeService)); | ||
| var provider = CreateServiceProvider(collection); | ||
|
|
||
| // Act | ||
| var serviceProviderIsService = provider.GetService<IServiceProviderIsService>(); | ||
|
|
||
| // Assert | ||
| Assert.NotNull(serviceProviderIsService); | ||
| Assert.True(serviceProviderIsService.IsService(typeof(IFakeService))); | ||
| Assert.False(serviceProviderIsService.IsService(typeof(FakeService))); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void OpenGenericsWithIsService() | ||
| { | ||
| // Arrange | ||
| var collection = new TestServiceCollection(); | ||
| collection.AddTransient(typeof(IFakeOpenGenericService<>), typeof(FakeOpenGenericService<>)); | ||
| var provider = CreateServiceProvider(collection); | ||
|
|
||
| // Act | ||
| var serviceProviderIsService = provider.GetService<IServiceProviderIsService>(); | ||
|
|
||
| // Assert | ||
| Assert.NotNull(serviceProviderIsService); | ||
| Assert.True(serviceProviderIsService.IsService(typeof(IFakeOpenGenericService<IFakeService>))); | ||
| Assert.False(serviceProviderIsService.IsService(typeof(IFakeOpenGenericService<>))); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void ClosedGenericsWithIsService() | ||
| { | ||
| // Arrange | ||
| var collection = new TestServiceCollection(); | ||
| collection.AddTransient(typeof(IFakeOpenGenericService<IFakeService>), typeof(FakeOpenGenericService<IFakeService>)); | ||
| var provider = CreateServiceProvider(collection); | ||
|
|
||
| // Act | ||
| var serviceProviderIsService = provider.GetService<IServiceProviderIsService>(); | ||
|
|
||
| // Assert | ||
| Assert.NotNull(serviceProviderIsService); | ||
| Assert.True(serviceProviderIsService.IsService(typeof(IFakeOpenGenericService<IFakeService>))); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void IEnumerableWithIsServiceAlwaysReturnsTrue() | ||
| { | ||
| // Arrange | ||
| var collection = new TestServiceCollection(); | ||
| collection.AddTransient(typeof(IFakeService), typeof(FakeService)); | ||
| var provider = CreateServiceProvider(collection); | ||
|
|
||
| // Act | ||
| var serviceProviderIsService = provider.GetService<IServiceProviderIsService>(); | ||
|
|
||
| // Assert | ||
| Assert.NotNull(serviceProviderIsService); | ||
| Assert.True(serviceProviderIsService.IsService(typeof(IEnumerable<IFakeService>))); | ||
| Assert.True(serviceProviderIsService.IsService(typeof(IEnumerable<FakeService>))); | ||
|
davidfowl marked this conversation as resolved.
|
||
| Assert.False(serviceProviderIsService.IsService(typeof(IEnumerable<>))); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
.../Microsoft.Extensions.DependencyInjection/tests/DI.Tests/ServiceProviderIsServiceTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
| using Microsoft.Extensions.DependencyInjection.Specification; | ||
|
|
||
| namespace Microsoft.Extensions.DependencyInjection.Tests | ||
| { | ||
| public class ServiceProviderIsServiceTests : ServiceProviderIsServiceSpecificationTests | ||
| { | ||
| protected override IServiceProvider CreateServiceProvider(IServiceCollection serviceCollection) => serviceCollection.BuildServiceProvider(); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.