Fix issue 14198: [Dark Mode] Improve visual contrast of the Group Headers in ListView control in dark#14406
Fix issue 14198: [Dark Mode] Improve visual contrast of the Group Headers in ListView control in dark#14406SimonZhao888 wants to merge 5 commits intodotnet:mainfrom
Conversation
…ders in ListView control in dark
There was a problem hiding this comment.
Pull request overview
This PR targets WinForms ListView dark mode rendering by improving the visual contrast of group headers (and related group text) when groups are enabled.
Changes:
- Adds custom dark-mode rendering logic for group header text, chevron, subtitle, and footer.
- Adjusts custom-draw flags and text color handling to receive group-related draw notifications and control group text colors.
- Updates the applied dark-mode theme identifier for the ListView/ColumnHeader to use the ItemsView theme.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/System.Windows.Forms/System/Windows/Forms/Controls/ListView/ListView.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/System/Windows/Forms/Controls/ListView/ListView.cs
Show resolved
Hide resolved
src/System.Windows.Forms/System/Windows/Forms/Controls/ListView/ListView.cs
Show resolved
Hide resolved
src/System.Windows.Forms/System/Windows/Forms/Controls/ListView/ListView.cs
Show resolved
Hide resolved
src/System.Windows.Forms/System/Windows/Forms/Controls/ListView/ListView.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Improves ListView group header readability in dark mode by adjusting theming/custom-draw behavior and adding an overlay render pass to redraw group header/subtitle/footer with higher-contrast styling.
Changes:
- Add dark-mode overlay drawing for group header/subtitle/footer and a custom chevron/underline rendering path.
- Adjust ListView custom draw flags/colors so group custom-draw notifications are raised and native group text is suppressed in dark mode.
- Switch the applied dark-mode theme identifier to
DarkMode_ItemsViewand attempt to configure group text colors viaLVM_SETGROUPMETRICS.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/System.Windows.Forms/System/Windows/Forms/Controls/ListView/ListView.cs
Show resolved
Hide resolved
src/System.Windows.Forms/System/Windows/Forms/Controls/ListView/ListView.cs
Show resolved
Hide resolved
src/System.Windows.Forms/System/Windows/Forms/Controls/ListView/ListView.cs
Show resolved
Hide resolved
src/System.Windows.Forms/System/Windows/Forms/Controls/ListView/ListView.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/System/Windows/Forms/Controls/ListView/ListView.cs
Show resolved
Hide resolved
|
Please consider Copilot's suggestion and complete the PR description |
I'm trying to add a selected overlay to a Group Item in Dark Mode. |
Fixes #14198
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Accessibility testing
Test environment(s)