Broken compatibility with custom url scheme plugin window.handleOpenURL method

[marcoNoeFi]

Bug report

CHECKLIST

• I have read the issue reporting guidelines
• I confirm this is a suspected bug or issue that will affect other users
• I have reproduced the issue using the example project or provided the necessary information to reproduce the issue.
• I have read the documentation thoroughly and it does not help solve my issue.
• I have checked that no similar issues (open or closed) already exist.
  Yes, it seems to be a bug: openUrl conflict on iOS #328 regression

Current behavior:
Broken compatibility with https://github.com/EddyVerbruggen/Custom-URL-scheme (tried installing both latest version 5.0.2 and from github msater branch)
With plugin version 14.0.0 the function window.handleOpenURL is not called when opening the app through a registered custom url scheme on iOS
The same code works with plugin version 13.0.1

Expected behavior:
function window.handleOpenURL should be called when opening through a registered custom url scheme

Steps to reproduce:

1. Install version 14.0.0 in combination with https://github.com/EddyVerbruggen/Custom-URL-scheme
2. Declare window.handleOpenURL as described in the other plugin README.md
3. Verify that window.handleOpenURL is never called.
4. Install previous version 13.0.1 and verify that window.handleOpenURL is called.

Screenshots
N/A

Environment information

• Cordova CLI version
  tested with 10.0.0 and 11.0.0

• Cordova platform version
  ios 6.0.2

• Plugins & versions installed in project (including this plugin)

• Dev machine OS and version, e.g.
  OSX 12.2.1

Runtime issue

• Device details
  iPhone13 emulator, iPhone 8 plus emulator, iPhone 8 real device, iPhoneX real device
• OS details
  iOS 15.0 / iOS 15.3.1

iOS build issue:

• Node JS version
  v12.18.2
• XCode version
  13.1

[DavidStrausz]

@dpa99c The problem seems to be the GoogleSignin v6 update and in particular the following addition:

f84fe16#diff-f722b2da065ecdbafd682e0ecd4bde102436b45638678ac1505604e796d3cb76R291

Probably it can just be removed and the override from #328 will handle the url correctly.

[JonSmart]

We have this issue, impacting another SDK that requires which also relies on access to application openUrl. v13 works.

I can confirm that removing the block of code referenced by David above does indeed correct the issue, however I am not sure if this will cause the GID to fail - it does appear to have a fallback 13.0.1-cli...14.0.0-cli#diff-aabfc02452b99b2b0599b43d56d206ac7302aa58201bdbeb855984067baf4682R154

Which also gets called if the first block of code is removed.

[jpike88]

I've opened PR #731 that hopefully is a step to resolving the issue, in a way that doesn't break existing google sign in functionality.

@dpa99c I have tested it, and it appears to work well. Can you please confirm whether you're willing to merge and publish a new version, or whether this repo is now in a deprecated state?

[dpa99c]

I'll make some time this week to test and merge this and address some of the outstanding issues. Sorry I don't use this plugin much anymore but I appreciate that others do so I'll try to get a release out by the end of the week

[jpike88]

@dpa99c much appreciated, keenly awaiting release :)

[pprattis]

@dpa99c @jpike88 The PR #731 was merged, but for v14.1.0 the conflicting code is still present

cordova-plugin-firebasex/src/ios/AppDelegate+FirebasePlugin.m

Line 291 in 2b56f92

- (BOOL)application:(nonnull UIApplication *)application

[jpike88]

sorry I've moved onto a combo of https://github.com/onesignal/OneSignal-Cordova-SDK and https://github.com/russmedia-digital/cordova-plugin-google-signin.

This lib has been great but the Google JS sdk/firebase team have been a major letdown, I've decided to just ditch firebase altogether because of poor 1st party Cordova support

[dpa99c]

Bugfix to resolve the merge error that erroneously re-introduced the openURL delegate has been published to npm in cordova-plugin-firebasex@14.2.1