Skip to content

fix: Integration with GoogleTagManager#906

Merged
dpa99c merged 2 commits intodpa99c:devfrom
MaximBelov:fix-integration-with-google-tag-manager
Nov 22, 2024
Merged

fix: Integration with GoogleTagManager#906
dpa99c merged 2 commits intodpa99c:devfrom
MaximBelov:fix-integration-with-google-tag-manager

Conversation

@MaximBelov
Copy link
Copy Markdown

@MaximBelov MaximBelov commented Nov 13, 2024

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

Please check your PR fulfills the following requirements:

Bugfixes:

  • Regression testing has been carried out using the example project to ensure the intended bug is fixed and no regression bugs have been inadvertently introduced.

New features/enhancements:

  • Exhaustive testing has been carried out for the new functionality
  • Regression testing has been carried out to ensure no existing functionality is adversely affected
  • Documentation has been added / updated
  • The example project has been update to validate/demonstrate the new functionality.

What is the purpose of this PR?

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

What testing has been done on existing functionality?

Other information

Comment thread scripts/ios/helper.js Outdated
@MaximBelov MaximBelov changed the title Fix integration with GoogleTagManager fix: Integration with GoogleTagManager Nov 19, 2024
@MaximBelov MaximBelov force-pushed the fix-integration-with-google-tag-manager branch from e6f7982 to 0bf20d3 Compare November 20, 2024 05:29
@MaximBelov MaximBelov marked this pull request as ready for review November 20, 2024 05:29
@dpa99c dpa99c changed the base branch from master to dev November 22, 2024 07:53
@dpa99c dpa99c merged commit f6e4353 into dpa99c:dev Nov 22, 2024
@MaximBelov MaximBelov deleted the fix-integration-with-google-tag-manager branch November 22, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants