add transparent border to setSliderColor#396
Merged
pvictor merged 1 commit intodreamRs:masterfrom Jul 5, 2021
Merged
Conversation
Member
|
Perfect 👌 , that's indeed better without that border Victor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi lovely dreamRs! 👋 I don't make pull requests to public packages often, and I don't know much about CSS, so feedback is welcome. 😊
I really appreciate your
setSliderColorfunction! I was using this function and noticed that the default border color on the slider is still blue, even when then slider color is set.I figured out that adding
border-color: transparentto the function can remove the blue outline, which may be a preferable default for those changing their slider colors. (I have no idea if spacing or anything matters in the function!)Just a thought! Thanks for considering.