Skip to content

make switchInput themable#454

Merged
pvictor merged 1 commit intodreamRs:masterfrom
AshesITR:feature/452-theme-switchInput
Dec 21, 2021
Merged

make switchInput themable#454
pvictor merged 1 commit intodreamRs:masterfrom
AshesITR:feature/452-theme-switchInput

Conversation

@AshesITR
Copy link
Copy Markdown
Contributor

closes #452

Upgraded bootstrap-switch to 3.4 and tested the changes interactively in shinyWidgetsGallery()
devtools::check() also runs fine.

I also added .idea to .gitignore and .Rbuildignore.
.idea contains local PyCharm project settings, similar to .Rproj.user for RStudio.

closes dreamRs#452

Upgraded bootstrap-switch to 3.4, tested interactively in shinyWidgetsGallery()

I also added .idea to .gitignore and .Rbuildignore.
.idea contains local PyCharm project settings, similar to .Rproj.user for RStudio.
@AshesITR
Copy link
Copy Markdown
Contributor Author

The failing check (ubuntu 16.04) seems unrelated to this PR.

@pvictor pvictor merged commit 191fdf7 into dreamRs:master Dec 21, 2021
@pvictor
Copy link
Copy Markdown
Member

pvictor commented Dec 21, 2021

Nice work @AshesITR ! 👍
Thank you very much!

Victor

@AshesITR AshesITR deleted the feature/452-theme-switchInput branch December 21, 2021 22:46
@pvictor
Copy link
Copy Markdown
Member

pvictor commented Jan 10, 2022

I submit to CRAN and forgot to add you in NEWS, sorry 😞

@ncuriale
Copy link
Copy Markdown

ncuriale commented Jan 31, 2022

with this change, i am unable to change the button size to "mini". even though data-size in the html is set as mini, the bsswitch classes are undefined. any idea here?
image

shinyWidgets::switchInput(inputId` = ns("spread_disabled"),
                                      inline = TRUE,
                                      label = "Spread",
                                      onLabel = 'Disabled',
                                      offLabel = 'Enabled',
                                      onStatus = 'danger',
                                      offStatus = 'primary',
                                      size = "mini", 
                                      value = FALSE)
```

![image](https://user-images.githubusercontent.com/23648811/151838618-13bba0f5-4267-4c15-9cf9-fc76b07186f1.png)

@AshesITR
Copy link
Copy Markdown
Contributor Author

Can you try on the current master branch, @ncuriale ?
It seems to have been fixed by #464 (we downgraded bsswitch to 3.3.4 from 3.4 in that PR).

If the issue still remains, I recommend opening a new issue with a reproducible example.
cc @pvictor do you know whether #464 made it to CRAN? If not, maybe a minor bugfix release would be nice.

@ncuriale
Copy link
Copy Markdown

yep looks like the downgrade solved the problem - the current master branch is working as expected. thanks

@pvictor
Copy link
Copy Markdown
Member

pvictor commented Feb 1, 2022

Not yet on CRAN! I will submit a release by the end of the week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make switchInput themable

3 participants