make switchInput themable#454
Merged
pvictor merged 1 commit intodreamRs:masterfrom Dec 21, 2021
Merged
Conversation
closes dreamRs#452 Upgraded bootstrap-switch to 3.4, tested interactively in shinyWidgetsGallery() I also added .idea to .gitignore and .Rbuildignore. .idea contains local PyCharm project settings, similar to .Rproj.user for RStudio.
Contributor
Author
|
The failing check (ubuntu 16.04) seems unrelated to this PR. |
Member
|
Nice work @AshesITR ! 👍 Victor |
Member
|
I submit to CRAN and forgot to add you in NEWS, sorry 😞 |
Contributor
Author
|
Can you try on the current master branch, @ncuriale ? If the issue still remains, I recommend opening a new issue with a reproducible example. |
|
yep looks like the downgrade solved the problem - the current master branch is working as expected. thanks |
Member
|
Not yet on CRAN! I will submit a release by the end of the week! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

closes #452
Upgraded bootstrap-switch to 3.4 and tested the changes interactively in shinyWidgetsGallery()
devtools::check() also runs fine.
I also added .idea to .gitignore and .Rbuildignore.
.idea contains local PyCharm project settings, similar to .Rproj.user for RStudio.