make 'create_tree' function faster#731
Open
eblondel wants to merge 1 commit intodreamRs:masterfrom
Open
Conversation
Member
|
Hello, |
Author
|
concepts.zip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @pvictor, here's some PR that intends to make
create_treefaster.WIth this PR, I led to decrease significantly the time required to build a tree for a large list of levels.
The context on which i'm working and that led to this PR is a R shiny app r-geoflow/geoflow-shiny as UI for for the R package r-geoflow/geoflow, in which i'm building a metadata editor that connects to vocabulary servers (powered by RDF/SKOS vocabularies). Some of these vocabularies can be very large, handling many collections of concepts.
See below a script that summaries the benchmarking I did on some large vocabulary (with 131,689 records). I attach the vocabular mentioned in this script as CSV, in case you want to reproduce. The code runs 25x faster with this PR.