Get attestation from ETS or Session now checks for expiry.#13
Merged
Conversation
…turns sessions that are not expired.
k-cross
reviewed
Jan 29, 2024
k-cross
left a comment
There was a problem hiding this comment.
reviewed, and thank you for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
Samly.Assertioncached in ETS or the Session will eventually expire.Samly.State.Store.get_assertion/3will return currently expired sessions. This is problematic because theSamly.AuthHandlerlooks for the cached session and doesn't replace it even if it is expired.This is further exacerbated by
Samly.get_active_assertion/1returning expired assertions.To address this I've updated the session and ETS logic to no longer return an expired session.
I contemplated purging ETS based on time, but it's most likely that the session store is being used in production.