feat: warn on hardcoded sync secrets#503
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Pushed Added focused Local validation:
|
|
🎉 Thanks for the clean implementation of #424! A few things I particularly liked:
I'll add the Also, looking across #496–#504: polish work (#496), a Protocol extension (#497), a Postgres bug fix (#498), docs visualization (#502), this PR's security feature, and a new destination (#504) — that's a remarkable breadth of contributions across different layers of the codebase in a short span. The fact that each PR is scoped at an independently reviewable granularity is genuinely helpful on the maintainer side too. Thanks again, and looking forward to more 🙏 |
Summary
syncs/*.ymlwith known token patterns and a Shannon entropy fallback.drt validateas warnings while keeping the default exit code at 0.drt validate --strictto promote warnings to validation errors, and include warning details in JSON output.Closes #424
Validation
uv run pytest tests/unit/test_cli_validate.py -vuv run pytest tests/unit/test_deprecations.py tests/unit/test_cli_validate.py -vuv run ruff check drt/config/secrets.py drt/cli/main.py tests/unit/test_cli_validate.pyuv run mypy drt/config/secrets.py drt/cli/main.pygit diff --checkuv run drt validate --helpdestination.auth.tokenwarns with exit 0, and--strictreports the same finding as an error with exit 1.