Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
…of experimental widget.
…and rename for clarity.
…ces from SettingsViewModel.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactored the widget experiment infrastructure by replacing experiment-based approach with feature toggles. This cleanup removes complex experiment tracking code and introduces simpler toggle-based implementations.
- Removed experiment classes and their tracking infrastructure
- Migrated to feature toggle-based widget control
- Updated all dependencies to use new toggle interfaces
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| SystemSearchViewModel.kt | Removed widget experiment tracking calls and constructor dependencies |
| SettingsViewModel.kt | Replaced experiment with toggle-based widget prompt detection |
| CtaViewModel.kt | Updated to use toggle interface instead of experiment class |
| SearchWidgetLifecycleDelegate.kt | Removed experiment tracking from widget lifecycle methods |
| BrowserTabFragment.kt | Updated import and dialog class name references |
| PostCtaExperienceToggles.kt | New toggle interface for post-CTA experience features |
| OnboardingHomeScreenWidgetToggles.kt | New toggle interface for onboarding widget features |
| AlternativeHomeScreenWidgetBottomSheetDialog.kt | Moved and renamed dialog class with corrected imports |
| Test files | Updated all test files to use new toggle interfaces instead of mock experiments |
app/src/main/java/com/duckduckgo/widget/SearchWidgetLifecycleDelegate.kt
Show resolved
Hide resolved
...ckduckgo/app/browser/ui/dialogs/widgetprompt/AlternativeHomeScreenWidgetBottomSheetDialog.kt
Show resolved
Hide resolved
…and update bindings.
landomen
approved these changes
Sep 11, 2025
Contributor
landomen
left a comment
There was a problem hiding this comment.
Great cleanup and works as expected 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1200581511062568/task/1210824886441068?focus=true
Description
Refactored the widget-related experiment implementation by replacing the experiment-based approach with feature toggles.
OnboardingHomeScreenWidgetExperimentandPostCtaExperienceExperimentclasses and their implementationsOnboardingHomeScreenWidgetTogglesandPostCtaExperienceTogglesinterfaces to use simple feature togglesThe PR removes complex experiment tracking code and replaces it with a more straightforward feature toggle implementation, making the codebase more maintainable and easier to understand.
Steps to test this PR
NO UI changes, reference screenshots