Skip to content

Improve controller security, error handling and page layout#105

Merged
duncdrum merged 5 commits into
eXist-db:masterfrom
line-o:feat/controller-security-error-handling
Aug 31, 2025
Merged

Improve controller security, error handling and page layout#105
duncdrum merged 5 commits into
eXist-db:masterfrom
line-o:feat/controller-security-error-handling

Conversation

@line-o

@line-o line-o commented Aug 2, 2025

Copy link
Copy Markdown
Member
  • fixes cross links to documentation apps are broken #16
  • all XQuery modules follow naming conventions
  • page layout improved
    • footer sticks to bottom of the window
    • module info improved (info icon alignment, box margins)
    • function info improved (duplicate function name removed)
  • controller only allows specific routes
  • POST /modules/reindex.xql replaced with GET /regenerate
  • scan.xql rewritten to generate.xqm

-- edit --
The todos in here were misleading. I will open issues with those enhancements we do at some point

Screenshots

Visual differences:
New on the left, old on the right

Screenshot 2025-08-01 at 21 52 59 Screenshot 2025-08-01 at 21 57 16 Screenshot 2025-08-01 at 21 56 37 Screenshot 2025-08-01 at 21 53 35

line-o added 2 commits August 2, 2025 11:04
- footer sticks to the bottom of the window
- improve module info display
  - info icon size and alignment
  - module info boottom and right margin
  - module description foont size
- improve function info display
  - remove duplicate function name
- rewrite scan.xql to generate.xqm
- adhere to naming conventions
- explicitly allow routes and deny evertying else
- route modules/reindex.xql moved to /regenerate
- add routes fro markdown and static resources
- call to /regenerate is a GET request
@line-o line-o requested review from a team and duncdrum August 2, 2025 09:27
@line-o line-o force-pushed the feat/controller-security-error-handling branch from 92297b3 to a4b1876 Compare August 2, 2025 09:31
- use new route `/exist/apps/fundocs/generate`
- do not test for removed headline in function info
- test for changed module name
@line-o line-o force-pushed the feat/controller-security-error-handling branch from a4b1876 to ff5ee89 Compare August 2, 2025 11:03
@dizzzz dizzzz requested a review from a team August 17, 2025 19:15

@duncdrum duncdrum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor suggestion

Comment thread src/test/cypress/integration/fundoc_spec.cy.js Outdated
@line-o

line-o commented Aug 28, 2025

Copy link
Copy Markdown
Member Author

I would like to incorporate 05d22d6 in this PR as it's not breaking and solving a major, user-facing issue.

I see it is already in here :)

Then we merge it and cut a new release which can go live on exist-db.org

@duncdrum duncdrum merged commit b6c1d75 into eXist-db:master Aug 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cross links to documentation apps are broken

3 participants