Merged
Conversation
Added functionality to analyzer.py for skyline to feed all of its own metrics
back to graphite. This results in skyline analyzing its own metrics for free :)
The resultant graphite metrics and carbon files (if using whisper and not ceres)
that this provides are (e.g):
skyline/
├── analyzer
│ ├── anomaly_breakdown
│ │ ├── first_hour_average.wsp
│ │ ├── grubbs.wsp
│ │ ├── histogram_bins.wsp
│ │ ├── ks_test.wsp
│ │ ├── least_squares.wsp
│ │ ├── mean_subtraction_cumulation.wsp
│ │ ├── median_absolute_deviation.wsp
│ │ ├── stddev_from_average.wsp
│ │ └── stddev_from_moving_average.wsp
│ ├── duration.wsp
│ ├── exceptions
│ │ ├── Boring.wsp
│ │ └── Stale.wsp
│ ├── projected.wsp
│ ├── run_time.wsp
│ ├── total_analyzed.wsp
│ ├── total_anomalies.wsp
│ └── total_metrics.wsp
└── horizon
└── queue_size.wsp
There will be more for other exceptions and any further added algorithms, this
is however quite trivial in terms of whisper storage and new metrics adds.
Modified:
src/analyzer/analyzer.py
Added skyline.analyzer.anomaly_breakdown. to SKIP_LIST Modified: src/settings.py.example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per etsy/skyline#90