Skip to content

meshcontroller: improve service instance search performance in Master #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xxx7xxxx merged 2 commits into from
Mar 7, 2026
Merged

meshcontroller: improve service instance search performance in Master #1503

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e7b0eb
meshcontroller: improve service instance search performance in Master
google-labs-jules[bot] Mar 3, 2026
ac6e9cc
Update pkg/object/meshcontroller/master/master.go
LokiWager Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions pkg/object/meshcontroller/master/master.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,18 +139,21 @@ func (m *Master) checkServiceInstances() {
statuses := m.service.ListAllServiceInstanceStatuses()
specs := m.service.ListAllServiceInstanceSpecs()

type instanceKey struct {
serviceName string
instanceID string
}
statusMap := make(map[instanceKey]*spec.ServiceInstanceStatus, len(statuses))
for _, s := range statuses {
statusMap[instanceKey{s.ServiceName, s.InstanceID}] = s
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The composite key literals rely on positional field order, which is easy to accidentally swap later. Prefer keyed struct literals for clarity and safety (e.g., instanceKey{serviceName: ..., instanceID: ...}).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@xxx7xxxx xxx7xxxx Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

}

for _, _spec := range specs {
if !m.isMeshRegistryName(_spec.RegistryName) {
continue
}

// TODO: improve search performance
var status *spec.ServiceInstanceStatus
for _, s := range statuses {
if s.ServiceName == _spec.ServiceName && s.InstanceID == _spec.InstanceID {
status = s
}
}
status := statusMap[instanceKey{_spec.ServiceName, _spec.InstanceID}]
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The composite key literals rely on positional field order, which is easy to accidentally swap later. Prefer keyed struct literals for clarity and safety (e.g., instanceKey{serviceName: ..., instanceID: ...}).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@xxx7xxxx xxx7xxxx Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback


if status == nil {
format := "status of %s/%s not found, need to delete"
Expand Down
Loading
⚡