use --no-deps when installing .whl in TensorFlow easyblock if extension are being installed, move test run to sanity check#1537
Conversation
… test run to sanity check, don't create google/__init__.py in TF install dir
…fig include extensions
…n bindings are installed as an extension
…nsions as Python packages using pip
|
@akesandgren After some further testing (& thinking), I've made a couple of changes:
Are you up for reviewing this & retesting easybuilders/easybuild-easyconfigs#6940 (which I also changed to use |
|
Working on Amber at the moment, and going to GTC next week so it might take a while before I have time. |
akesandgren
left a comment
There was a problem hiding this comment.
These changes look good and fixes the potential problems.
|
I've verified that this works both with the updated easyconfigs for TensorFlow 1.10.x (cfr. easybuilders/easybuild-easyconfigs#6940) and for existing untouched |
This fixes the problem reported by @agijsberts in #1536, by also using
--no-depsin thepip installcommand.This change implies that all additional Python packages required by
TensorFlowthat are not available in thePythoninstallation (e.g.numpyis) are included in the easyconfig file as extensions, so allTensorFloweasyconfig files that use this easyblock will need to be fixed...Two other changes are also required:
running the MNIST tutorial example as a test now must be done in the sanity check, since not all extension are available yet after the
pip installof the generated.whl; the comment claiming that this couldn't be done in the sanity check step was incorrect, since the build dir isn't cleaned up yetcreating of
google/__init__.pynow doesn't make sense anymore since theprotobufPython package will not be installed automagically anymore (instead, it should be listed as a dependency in theTensorFloweasyconfig file)