let CMakeMake remove 'easybuild_obj' build directory if it already exists#2032
Merged
boegel merged 1 commit intoeasybuilders:developfrom May 19, 2020
Merged
let CMakeMake remove 'easybuild_obj' build directory if it already exists#2032boegel merged 1 commit intoeasybuilders:developfrom
boegel merged 1 commit intoeasybuilders:developfrom
Conversation
without also ensuring that the directories that are used for that build are also unique there are build problems with bundles that contain more than one CMake package and didn’t explicitly set separate_build_dir to false This also applies partially to multiple iterations of the same software build (e.g. configopts) As the build directory is unique to EasyBuild it is save to remove
boegel
requested changes
Apr 16, 2020
Contributor
Author
|
@boegel
Edit: Current best option: use a named and numbered unique folder. Check |
Member
|
Merging this for inclusion in EasyBuild v4.2.1. As discussed with @Flamefire, this improves the current situation (it fixes some use cases), even though it may not be perfect and cover every possible use case. We can follow up in another PR (cfr. #2036 (comment)). |
boegel
approved these changes
May 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without also ensuring that the directories that are used for that build are also unique
there are build problems with bundles that contain more than one CMake package and didn’t
explicitly set separate_build_dir to false
This also applies partially to multiple iterations of the same software build (e.g. configopts)
Reported in #1933 (comment)
As the build directory is unique to EasyBuild it is safe to remove