ensure stand-alone Python package being installed is in view when running 'pip check' by loading fake module first#2114
Merged
smoors merged 1 commit intoeasybuilders:developfrom Aug 12, 2020
Conversation
…ning 'pip check' by loading fake module first
Member
Author
|
There's a whole bunch of easyconfigs we need to re-check to ensure there's no fallout from this bug. It definitely affects I'm wading through the easyconfigs that may be hit by this, to see if there's more problems to fix... |
This was referenced Aug 11, 2020
Contributor
|
all tests of the above easyconfig PRs succeeded with this easyblock PR included, except for LiBis, but that is due to an error in it's MOABS dependency. |
Contributor
|
Going in, thanks @boegel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not loading the fake module basically renders
pip checkuseless, since the dependencies are only being checked for Python packages which are "in view" (through$PYTHONPATH).This bug only affects stand-alone installation of Python packages (using the
PythonPackageeasyblock, or one that derives from it), not sets of Python packages being installed as extensions (either viaPythonBundle, or as extensions in thePythoninstallations or those of other software like GROMACS).PRs that should get merged when this is merged (to avoid breaking the installations of easyconfigs):
scikit-learn0.23.1 (PR install scikit-learn 0.23.1 as a bundle and include required threadpoolctl extension easybuild-easyconfigs#11089)archspec0.1.0 on top of Python 3.7.4 (PR add recent six as extension to archspec installed on top of Python 3.7.4 easybuild-easyconfigs#11092)OpenPIV-0.21.8-intel-2019b-Python-3.7.4.eb(PR add missing dependencies for OpenPIV + switch to PythonBundle easyblock and include progressbar2 as extension easybuild-easyconfigs#11096)LiBis-20200428-foss-2019b-Python-3.7.4.eb(PR add missing Seaborn dependency to LiBis easyconfig easybuild-easyconfigs#11095)TEtranscripts-2.2.0-foss-2020a.eb(PR add missing argparse dep to TEtranscripts easyconfig easybuild-easyconfigs#11097)Telescope-1.0.3-foss-2019b-Python-3.7.4.ebintervaltreeextension in included in Python 3.7.4 installation, see #10969)