Skip to content

fix OpenFOAM easyblock to support installation on Arm/aarch64 systems#2162

Merged
boegel merged 3 commits intoeasybuilders:developfrom
terjekv:aarch64_support_for_openfoam_v2
Sep 7, 2020
Merged

fix OpenFOAM easyblock to support installation on Arm/aarch64 systems#2162
boegel merged 3 commits intoeasybuilders:developfrom
terjekv:aarch64_support_for_openfoam_v2

Conversation

@terjekv
Copy link
Copy Markdown
Contributor

@terjekv terjekv commented Sep 3, 2020

  • More aarch64 compatibility fixes.
  • Different versions of OpenFOAM use different abbreviations for ARM64, or Arm64...

@boegel boegel added the aarch64 Related to Arm 64-bit (aarch64) label Sep 3, 2020
@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Sep 4, 2020

@terjekv Can you close #2161 since this one replaces it?

@terjekv
Copy link
Copy Markdown
Contributor Author

terjekv commented Sep 4, 2020

Sorted. They were supposed to be compatible, but the develop merging seems to have gone awry. Sorry. :-(

@terjekv
Copy link
Copy Markdown
Contributor Author

terjekv commented Sep 4, 2020

A test report is on its way, it'll take a few hours due to both OpenFOAM variants needing a full build.

@terjekv
Copy link
Copy Markdown
Contributor Author

terjekv commented Sep 7, 2020

This is odd, I ran a test report with the easyblock, but I'm not sure where the test result ended up?

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 7, 2020

This is odd, I ran a test report with the easyblock, but I'm not sure where the test result ended up?

You hit a known bug that we haven't fixed yet, see easybuilders/easybuild-framework#3289

Your test report is there though, there's just no corresponding comment for it: https://gist.github.com/terjekv/993437e9e5b14f67e68a33dc57f54809

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the next release (4.3.0) milestone Sep 7, 2020
@boegel boegel changed the title Different OpenFOAM variants are... different. fix OpenFOAM easyblock to support installation on Arm/aarch64 systems Sep 7, 2020
@boegel boegel merged commit f50a85d into easybuilders:develop Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aarch64 Related to Arm 64-bit (aarch64)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants