add easyblock for RELION#2274
Open
lexming wants to merge 5 commits intoeasybuilders:developfrom
Open
Conversation
Member
Contributor
Author
|
@migueldiascosta fix for those tests in #2302 |
Contributor
Author
|
Successful test report in easybuilders/easybuild-easyconfigs#10965 (comment) |
Contributor
|
It might be useful to split out the part concerning batch/queue systems (i.e. Slurm/Torque/LSF(?)) and their particulars to its own easyblock for use by others that might want to use it. I don't know what the EB framework uses for when it uses jobs to build things (I've always just built on the login nodes), but it might be able to use it too. Just a thought. |
Contributor
|
Two other quick thoughts (although maybe best for a later update):
|
shahpnmlab
reviewed
Nov 18, 2021
shahpnmlab
left a comment
There was a problem hiding this comment.
Line 171, results in a str float comparison which is not valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on
#2280and#2302Easyconfig in easybuilders/easybuild-easyconfigs#10965