update NEURON easyblock to use CMakeMake for recent versions by mboisson · Pull Request #2304 · easybuilders/easybuild-easyblocks

mboisson · 2021-01-07T19:18:03Z

This change

Updates the Neuron EasyBlock to use CMakeMake for recent versions
Adds support for multi_deps python
Added testing of python
Updates sanity checks for version 7.8

mboisson · 2021-01-07T19:20:17Z

@boegel, @Flamefire, since you both commented on Slack, tagging you

Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>

… to build code

akesandgren

LGTM

akesandgren · 2022-02-14T11:35:39Z

@boegel Are you ok with this? There has been some discussions back and forth and I'm not sure of the final outcome.

boegel · 2022-02-16T15:23:40Z

@akesandgren We definitely need a test report with existing NEURON easyconfigs for this.

Also, is there a PR with an easyconfig for a recent version of NEURON?

fix configure command for NEURON < 7.8.1, shouldn't be cmake

boegel · 2022-06-03T12:45:23Z

Test report by @boegel

Overview of tested easyconfigs (in order)

SUCCESS NEURON-7.4-intel-2016b.eb
SUCCESS NEURON-7.6.5-intel-2018b-Python-2.7.15.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2621.swalot.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/008f8db51375bfb4cd3886355687a7b5 for a full test report.

mboisson added 3 commits January 7, 2021 19:15

updating neuron EasyBlock to use CMakeMake and support multi_deps python

f4408ad

added authorship

b9f0bda

appeasing hound

12428ff

mboisson mentioned this pull request Jan 7, 2021

Building from tarball fails neuronsimulator/nrn#899

Closed

fixed undefined variable

a29260a

pramodk reviewed Jan 7, 2021

View reviewed changes

changed version test from 7.8 to 7.8.1

6fb8d9a

Flamefire reviewed Jan 8, 2021

View reviewed changes

Comment thread easybuild/easyblocks/n/neuron.py Outdated

Flamefire reviewed Jan 8, 2021

View reviewed changes

Comment thread easybuild/easyblocks/n/neuron.py Outdated

Flamefire reviewed Jan 8, 2021

View reviewed changes

Comment thread easybuild/easyblocks/n/neuron.py Outdated

Flamefire reviewed Jan 8, 2021

View reviewed changes

Comment thread easybuild/easyblocks/n/neuron.py Outdated

mboisson and others added 3 commits January 8, 2021 09:43

Update easybuild/easyblocks/n/neuron.py

29530ed

Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>

fixed sanity check dirs and binaries

b411819

appeasing hound

a41450b

boegel requested changes Jan 8, 2021

View reviewed changes

Comment thread easybuild/easyblocks/n/neuron.py Outdated

Comment thread easybuild/easyblocks/n/neuron.py

Comment thread easybuild/easyblocks/n/neuron.py

Comment thread easybuild/easyblocks/n/neuron.py Outdated

boegel changed the title ~~Neuron cmake~~ update NEURON easyblock to use CMakeMake for recent versions Jan 8, 2021

mboisson added 6 commits January 8, 2021 15:52

simplify extra_options

0bf4861

combined common binaries and switched back to custom_paths

4aedb10

removed EBPYTHONPREFIXES and PYTHONPATH from make_module_req_guess

e87df15

removed extra return txt

2e1b9a7

re-instated the use of sanity_check_paths instead of custom_paths

2adc723

adding environment variables CXX, MPICC, MPICXX for Neuron to be able…

8cd5c4e

… to build code

mboisson commented Jan 8, 2021

View reviewed changes

Comment thread easybuild/easyblocks/n/neuron.py

pramodk mentioned this pull request Jan 8, 2021

source code releases on github? neuronsimulator/nrn#182

Closed

boegel added the update label Feb 3, 2021

boegel added this to the 4.x milestone Feb 3, 2021

akesandgren reviewed May 24, 2021

View reviewed changes

Comment thread easybuild/easyblocks/n/neuron.py Outdated

akesandgren reviewed May 24, 2021

View reviewed changes

Comment thread easybuild/easyblocks/n/neuron.py

enable interviews if available, disable python if not

08134de

akesandgren previously approved these changes May 25, 2021

View reviewed changes

fix configure command for NEURON < 7.8.1, shouldn't be cmake

db23114

boegel mentioned this pull request Jun 3, 2022

fix configure command for NEURON < 7.8.1, shouldn't be cmake ComputeCanada/easybuild-easyblocks#10

Merged

boegel requested changes Jun 3, 2022

View reviewed changes

Comment thread easybuild/easyblocks/n/neuron.py

Merge pull request #10 from boegel/neuron_cmake

c950c13

fix configure command for NEURON < 7.8.1, shouldn't be cmake

bartoldeman dismissed akesandgren’s stale review via c950c13 June 3, 2022 11:59

boegel mentioned this pull request Jun 3, 2022

{bio}[foss/2021b] NetPyNE v1.0.2.1, NEURON v7.8.2 w/ Python 3.9.6 easybuilders/easybuild-easyconfigs#15606

Merged

boegel approved these changes Jun 3, 2022

View reviewed changes

boegel merged commit d4179f0 into easybuilders:develop Jun 3, 2022

boegel modified the milestones: 4.x, release after 4.5.5, 4.5.5 Jun 3, 2022

mboisson deleted the neuron_cmake branch June 3, 2022 13:21

Conversation

mboisson commented Jan 7, 2021

Uh oh!

mboisson commented Jan 7, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akesandgren left a comment

Choose a reason for hiding this comment

Uh oh!

akesandgren commented Feb 14, 2022

Uh oh!

boegel commented Feb 16, 2022

Uh oh!

Uh oh!

boegel commented Jun 3, 2022

Overview of tested easyconfigs (in order)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants