Skip to content

update LAPACK easyblock to keep control of compiler options for versions >= 3.9.0#2358

Merged
akesandgren merged 3 commits intoeasybuilders:developfrom
boegel:20210312100641_new_pr_VYkYYdSgBj
Mar 16, 2021
Merged

update LAPACK easyblock to keep control of compiler options for versions >= 3.9.0#2358
akesandgren merged 3 commits intoeasybuilders:developfrom
boegel:20210312100641_new_pr_VYkYYdSgBj

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 12, 2021

(created using eb --new-pr)

@boegel boegel added this to the next release (4.3.4?) milestone Mar 12, 2021
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 12, 2021

Oh hold on, the NOOPT variable was also renamed to FFLAGS_NOOPT...

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 12, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS LAPACK-3.8.0-GCC-7.3.0-2.30.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2672.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/1e6f3aae6d3225403f4b8a06f49a463e for a full test report.

@boegel boegel mentioned this pull request Mar 12, 2021
Merged
akesandgren
akesandgren reviewed Mar 15, 2021
View reviewed changes
Comment thread easybuild/easyblocks/l/lapack.py Outdated
else:
fflags_var = 'OPTS'
noopt_var = 'NOOPT'
self.cfg.update('buildopts', '%s="%s -m64"' % (fflags_var, os.getenv('FFLAGS')))
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if explicitly setting -m64 is a good thing here and below.

Copy link
Copy Markdown
Member Author

@boegel boegel Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to drop this, but it's just copying what the LAPACK Makefile does.

Any specific reason you think this is not a good idea?

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren Mar 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no -m64 anywhere in the LAPACK files whatsoever.
-m64 is compiler specific, not all compilers has that flag.

@boegel boegel dismissed a stale review via 0b63ceb March 16, 2021 10:16
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 16, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS LAPACK-3.8.0-GCC-7.3.0-2.30.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3140.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/a4b3f6827a79d4fc2ad8d0f4205398af for a full test report.

akesandgren
akesandgren approved these changes Mar 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Mar 16, 2021

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 79df00a into easybuilders:develop Mar 16, 2021
@boegel boegel deleted the 20210312100641_new_pr_VYkYYdSgBj branch March 16, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees

No one assigned

Labels

bug fix update

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @akesandgren
⚡