Skip to content

Don't unpack whl files by default in generic PythonPackage easyblock#2366

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:dontUnpackWhlsByDefault
Apr 29, 2021
Merged

Don't unpack whl files by default in generic PythonPackage easyblock#2366
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:dontUnpackWhlsByDefault

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

Especially with the introduction of easybuilders/easybuild-framework#3618 Wheels may become more common as (THE) valid installation approach for Python packages via pip. Having to specify unpack_sources = False every time is annoying and feels like something is off.
This basically adds first-class support whl-files by NOT unpacking them by default.

This could be considered a breaking change for cases where whl files were used and they should be unpacked without explicitly specifying unpack_sources = True (as that was the default), but I don't think it was even possible to do that meaningfully, so I'd say the valid cases that this breaks are unicorn rare.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS pkgconfig-1.5.1-GCCcore-8.2.0-python.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
taurusa4 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz (broadwell), Python 2.7.5
See https://gist.github.com/6e391ca923ed2e51057ea6df0fbbae63 for a full test report.

@Flamefire Flamefire force-pushed the dontUnpackWhlsByDefault branch from de6224d to fd1a501 Compare March 29, 2021 09:06
Copy link
Copy Markdown

@hound hound Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Mar 29, 2021

This is a test to show a failing report only!

Test report by @Flamefire

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 1 (1 easyconfigs in total)
taurusa4 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz (broadwell), Python 2.7.5
See https://gist.github.com/859650686eab87d18c197ce207283f32 for a full test report.

Comment thread easybuild/easyblocks/generic/pythonpackage.py Outdated
@boegel boegel changed the title Don't unpack whl files by default Don't unpack whl files by default in generic PythonPackage easyblock Mar 31, 2021
@boegel boegel added this to the 4.x milestone Mar 31, 2021
@Flamefire Flamefire force-pushed the dontUnpackWhlsByDefault branch from b02aff2 to 280ee72 Compare April 6, 2021 10:48
@Flamefire
Copy link
Copy Markdown
Contributor Author

Rebased to resolve the conflict

@Flamefire Flamefire force-pushed the dontUnpackWhlsByDefault branch from 280ee72 to 7ab5d51 Compare April 27, 2021 14:35
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 28, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Ray-project-1.0.1-fosscuda-2019b-Python-3.7.4.eb
  • SUCCESS Python-3.8.6-GCCcore-10.2.0.eb
  • SUCCESS SciPy-bundle-2020.11-foss-2020b.eb
  • SUCCESS matplotlib-3.3.3-foss-2020b.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
node2660.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/89dea4a9bb5f0a1ab6d632f47ca8950f for a full test report.

@boegel boegel merged commit 71d338d into easybuilders:develop Apr 29, 2021
@Flamefire Flamefire deleted the dontUnpackWhlsByDefault branch April 29, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants