Don't unpack whl files by default in generic PythonPackage easyblock#2366
Conversation
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
de6224d to
fd1a501
Compare
|
This is a test to show a failing report only! Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
b02aff2 to
280ee72
Compare
|
Rebased to resolve the conflict |
280ee72 to
7ab5d51
Compare
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
Especially with the introduction of easybuilders/easybuild-framework#3618 Wheels may become more common as (THE) valid installation approach for Python packages via pip. Having to specify
unpack_sources = Falseevery time is annoying and feels like something is off.This basically adds first-class support whl-files by NOT unpacking them by default.
This could be considered a breaking change for cases where whl files were used and they should be unpacked without explicitly specifying
unpack_sources = True(as that was the default), but I don't think it was even possible to do that meaningfully, so I'd say the valid cases that this breaks are unicorn rare.