Skip to content

Fix accidental change of the default source_urls in the PythonPackage EB#2370

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:fixPYPISrc
Mar 26, 2021
Merged

Fix accidental change of the default source_urls in the PythonPackage EB#2370
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:fixPYPISrc

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Mar 26, 2021

The original list was modified as a side effect, a copy is required here

edit: fix for bug introduced in #2364

Copy link
Copy Markdown

@hound hound Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the next release (4.3.4?) milestone Mar 26, 2021
@boegel boegel added the bug fix label Mar 26, 2021
@boegel boegel merged commit 329bcc7 into easybuilders:develop Mar 26, 2021
@Flamefire Flamefire deleted the fixPYPISrc branch March 26, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants