Skip to content

Make sure OpenFOAM sanity checks don't require builddir write permissions#2415

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
ocaisa:openfoam_module_only
May 25, 2021
Merged

Make sure OpenFOAM sanity checks don't require builddir write permissions#2415
akesandgren merged 1 commit intoeasybuilders:developfrom
ocaisa:openfoam_module_only

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented May 10, 2021

Fixes #2400

openfoamdir_path = os.path.join(self.installdir, self.openfoamdir)
motorbike_path = os.path.join(openfoamdir_path, 'tutorials', 'incompressible', 'simpleFoam', 'motorBike')
if os.path.exists(motorbike_path):
test_dir = tempfile.mkdtemp()
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may cause issues if the example is run on more than one node

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it is fixable by setting the --tmpdir option to be on a parallel file system

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's safe to assume that in general EasyBuild isn't running in a multi-node context...

@ocaisa ocaisa added bug fix EESSI Related to EESSI project labels May 10, 2021
@boegel boegel added this to the next release (4.3.5?) milestone May 12, 2021
@akesandgren
Copy link
Copy Markdown
Contributor

Can we get generoso to make a test report for this ? Can't remember if that's easy to do?

@boegel
Copy link
Copy Markdown
Member

boegel commented May 24, 2021

@akesandgren Not easily currently, the bot only listens to requests in the easyconfigs repo.

I kicked off a couple of --module-only tests, results should be in soon...

@boegel
Copy link
Copy Markdown
Member

boegel commented May 24, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-6-foss-2019b.eb
  • SUCCESS OpenFOAM-7-foss-2019b-20200508.eb
  • SUCCESS OpenFOAM-7-foss-2019b.eb
  • SUCCESS OpenFOAM-8-foss-2020a.eb
  • SUCCESS OpenFOAM-8-foss-2020b.eb

Build succeeded for 5 out of 5 (5 easyconfigs in total)
node2618.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/22f3a51c5b5d77c63a6f179f5cedec59 for a full test report.

@boegelbot
Copy link
Copy Markdown

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-8-foss-2020b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/629e61e1834ce25ad7910d865a8fff47 for a full test report.

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @ocaisa!

@akesandgren akesandgren merged commit e073d84 into easybuilders:develop May 25, 2021
@boegel boegel changed the title Make sure OpenFOAM sanity checks don't requite builddir write permissions Make sure OpenFOAM sanity checks don't require builddir write permissions Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix EESSI Related to EESSI project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenFOAM sanity check requires write permission in installation directory

4 participants