Skip to content

obtain build_targets value via self.cfg.get in ConfigureMake easyblock#2480

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
boegel:fix_configuremake_build_targets
Jun 18, 2021
Merged

obtain build_targets value via self.cfg.get in ConfigureMake easyblock#2480
branfosj merged 1 commit intoeasybuilders:developfrom
boegel:fix_configuremake_build_targets

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jun 18, 2021

Fix for crash for easyblock that derive from ConfigureMake, but don't pick up the custom easyconfig parameters for ConfigureMake (like PerlModule, for example):

Use of unknown easyconfig parameter 'build_targets' when getting parameter valu

@boegel boegel added the bug fix label Jun 18, 2021
@boegel boegel added this to the next release (4.4.1) milestone Jun 18, 2021
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 18, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS PRINSEQ-0.20.4-foss-2018b-Perl-5.28.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2618.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/5d9f26815831fbb5df0f647e9dcde34b for a full test report.

Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member

Going in, thanks @boegel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants